MLEBABecLap aniso 2D and 3D#5216
Conversation
|
I only checked changes in 2D mlebabeclap_adotx_centroid. It does not seem correct to me. The grad_eb_of_phi_on_centroids_extdir function uses anrmx and anrmy as follows: If the return value is scaled by a constant, it can be re-scaled later. But in your change, the ratio of nrmx to nrmy has changed. So I don't see how that can be correct. |
|
In
This is why I scaled feb = beb * ( (apxm - apxp) dhx dx Apply definitions of feb = B * beb * ( |
So the proposed change in 2D is not just more consistency, right? |
|
Yes, I think you are right, it's more than just consistency. The extra dxi factor is necessary to actually get spatial derivatives. This effect only matters when dx =/= dy. My apologizes for not adding a test to this PR. I can convert to draft if that's more appropriate. |
|
No problems. I thought the 2D was just a programming style change and I was focusing on whether the 2D behavior has changed. |
Summary
Changes in MLEBABecLap for 3D and 2D to way flux is computed for EB surfaces.
The goal is removing the assumption that dx=dy=dz (anisotropic cells).
Additional background
The changes concern the way how Feb is computed. The changes in #2640 were only for 2D. This handles both 2D and 3D, with 2D changed to be more consistent with 3D.
Checklist
The proposed changes: